Skip to content

(fix) Fixing components/sdk package to not publish #14640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

(fix) Fixing components/sdk package to not publish #14640

merged 2 commits into from
Nov 13, 2024

Conversation

@dylburger
Copy link
Contributor

@dylburger dylburger commented Nov 12, 2024 •
edited by coderabbitai bot
Loading

(fix) Fixing components/sdk package to be private, so we no longer publish it

We had an incident where this package overwrote the packages/sdk version of the package.

Summary by CodeRabbit

  • New Features
    • Updated the version of the @pipedream/sdk component to 0.1.2, indicating enhancements or fixes.
    • Introduced a new configuration to prevent the components/sdk from being published.
  • Bug Fixes
    • Updated the version of the @pipedream/sdk package to 1.0.1, reflecting minor improvements.

@dylburger
(fix) Fixing components/sdk package to be private, so we no longer pu…
72edd27 
…blish it.

We had an incident where this package overwrote the packages/sdk version of the package.
@vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 5:27pm
pipedream-docs ⬜️ Ignored (Inspect) Nov 13, 2024 5:27pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Nov 13, 2024 5:27pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2024 •
edited
Loading

Walkthrough

The pull request includes updates to the package.json files across multiple components, primarily focusing on version increments and configuration changes. The @pipedream/sdk component's version is updated from 0.1.1 to 0.1.2, with the removal of the public access configuration and the addition of a private flag. Additionally, a new publishConfig property is introduced in the main package.json, indicating that the components/sdk should not be published. The packages/sdk version is also incremented from 1.0.0 to 1.0.1.

Changes

File Change Summary
components/sdk/package.json - Version updated from 0.1.1 to 0.1.2
- Removed publishConfig for public access
- Added private: true
package.json - Added publishConfig with value false for components/sdk
packages/sdk/package.json - Version updated from 1.0.0 to 1.0.1

Possibly related PRs

  • SDK triggers components skeleton #14637: The changes in this PR also involve modifications to the package.json file for the @pipedream/sdk, specifically updating the version number, which is directly related to the version update in the main PR.
  • Updating source names for SDK triggers #14638: This PR updates the package.json for the @pipedream/sdk, including a version increment and other modifications, which aligns with the version change in the main PR.

Suggested labels

bug

Suggested reviewers

  • jcortes
  • GTFalcao

Poem

In the garden of code, we hop with glee,
Versions updated, as bright as can be.
A private path now, no public display,
With each little change, we dance and we play!
So here’s to the tweaks, with joy we embrace,
In the world of our project, we find our place! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dylburger dylburger merged commit 119ebef into master Nov 13, 2024
12 checks passed
@dylburger dylburger deleted the fixing-pipedream-sdk-components-package-incident branch November 13, 2024 17:31
@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2024
Merged
lcaresia pushed a commit that referenced this pull request Dec 3, 2024
@dylburger @lcaresia
(fix) Fixing components/sdk package to be private, so we no longer pu…
852e0b2 
…blish it. (#14640)

We had an incident where this package overwrote the packages/sdk version of the package.
This was referenced Dec 4, 2024
Merged
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dylburger